From: Marcelo Tosatti Subject: [patch 4/6] remove unused kvm_dirty_bitmap array Date: Mon, 03 May 2010 19:48:23 -0300 Message-ID: <20100503224905.703505696@amt.cnet> References: <20100503224819.773169076@amt.cnet> Cc: avi@redhat.com, jan.kiszka@web.de, Marcelo Tosatti To: kvm@vger.kernel.org Return-path: Received: from mx1.redhat.com ([209.132.183.28]:41969 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759546Ab0ECW46 (ORCPT ); Mon, 3 May 2010 18:56:58 -0400 Content-Disposition: inline; filename=remove-unused-dirty-bitmap Sender: kvm-owner@vger.kernel.org List-ID: Signed-off-by: Marcelo Tosatti Index: qemu-kvm-memslot/qemu-kvm.c =================================================================== --- qemu-kvm-memslot.orig/qemu-kvm.c +++ qemu-kvm-memslot/qemu-kvm.c @@ -2154,7 +2154,6 @@ void kvm_set_phys_mem(target_phys_addr_t * dirty pages logging */ /* FIXME: use unsigned long pointer instead of unsigned char */ -unsigned char *kvm_dirty_bitmap = NULL; int kvm_physical_memory_set_dirty_tracking(int enable) { int r = 0; @@ -2163,17 +2162,9 @@ int kvm_physical_memory_set_dirty_tracki return 0; if (enable) { - if (!kvm_dirty_bitmap) { - unsigned bitmap_size = BITMAP_SIZE(phys_ram_size); - kvm_dirty_bitmap = qemu_malloc(bitmap_size); - r = kvm_dirty_pages_log_enable_all(kvm_context); - } + r = kvm_dirty_pages_log_enable_all(kvm_context); } else { - if (kvm_dirty_bitmap) { - r = kvm_dirty_pages_log_reset(kvm_context); - qemu_free(kvm_dirty_bitmap); - kvm_dirty_bitmap = NULL; - } + r = kvm_dirty_pages_log_reset(kvm_context); } return r; }