From: Marcelo Tosatti Subject: Re: [PATCH] KVM: VMX: Avoid writing HOST_CR0 every entry Date: Tue, 4 May 2010 11:54:31 -0300 Message-ID: <20100504145430.GB17508@amt.cnet> References: <1272896334-13474-1-git-send-email-avi@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org To: Avi Kivity Return-path: Received: from mx1.redhat.com ([209.132.183.28]:64138 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933397Ab0EDPDa (ORCPT ); Tue, 4 May 2010 11:03:30 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o44F3U00010579 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 4 May 2010 11:03:30 -0400 Content-Disposition: inline In-Reply-To: <1272896334-13474-1-git-send-email-avi@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Mon, May 03, 2010 at 05:18:54PM +0300, Avi Kivity wrote: > cr0.ts may change between entries, so we copy cr0 to HOST_CR0 before each > entry. That is slow, so instead, set HOST_CR0 to have TS set unconditionally > (which is a safe value), and issue a clts() just before exiting vcpu context > if the task indeed owns the fpu. > > Saves ~50 cycles/exit. > > Signed-off-by: Avi Kivity Looks good to me.