Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1O9j4G-0005lp-7b for qemu-devel@nongnu.org; Wed, 05 May 2010 14:11:32 -0400 Received: from [140.186.70.92] (port=47004 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O9j3z-00054s-NV for qemu-devel@nongnu.org; Wed, 05 May 2010 14:11:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1O9j3v-00007n-Bw for qemu-devel@nongnu.org; Wed, 05 May 2010 14:11:13 -0400 Received: from verein.lst.de ([213.95.11.210]:49493) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O9j3u-00007d-Uo for qemu-devel@nongnu.org; Wed, 05 May 2010 14:11:11 -0400 Date: Wed, 5 May 2010 20:11:10 +0200 From: Christoph Hellwig Subject: Re: [Qemu-devel] [PATCH 5/6] parallels: use pread Message-ID: <20100505181110.GB7839@lst.de> References: <20100504104351.GA6342@lst.de> <20100504104504.GE6388@lst.de> <4BE17E72.4020308@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4BE17E72.4020308@redhat.com> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org On Wed, May 05, 2010 at 04:19:30PM +0200, Kevin Wolf wrote: > position should be a signed int64_t, otherwise the condition is always true. Indeed, I'll update the patch.