From: Wolfgang Denk Date: Wed, 05 May 2010 23:57:29 +0200 Subject: [U-Boot] [PATCH] cmd_onenand.c: moved to standard subcommand handling In-Reply-To: <1269706476-20496-1-git-send-email-fransmeulenbroeks@gmail.com> References: <1269706476-20496-1-git-send-email-fransmeulenbroeks@gmail.com> Message-ID: <20100505215729.EC72FB0FF81@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Frans Meulenbroeks, In message <1269706476-20496-1-git-send-email-fransmeulenbroeks@gmail.com> you wrote: > On the fly also fixed the following things: > - write help talked about a parameter oob, but that one was not used, so > removed it from the help message. > - the test command also allowed a force subcommand but didn't use it. > eliminated the code. > - do_onenand made static > - do_onenand contained > int blocksize; > ... > mtd = &onenand_mtd; > this = mtd->priv; > blocksize = (1 << this->erase_shift); > As blocksize was not used the last two statements were unneeded so > removed them. > The first statement (mtd = ....) assigns to a global. Not sure if it > is needed, and since I could not test this, left the line for now > > Signed-off-by: Frans Meulenbroeks > --- > common/cmd_onenand.c | 307 +++++++++++++++++++++++++++++++------------------- > 1 files changed, 192 insertions(+), 115 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Life would be so much easier if we could just look at the source code. -- Dave Olson