Received: from [140.186.70.92] (port=60628 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OFUuv-0002WK-5O for qemu-devel@nongnu.org; Fri, 21 May 2010 12:19:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OFUun-0002KF-Uc for qemu-devel@nongnu.org; Fri, 21 May 2010 12:17:39 -0400 Received: from hall.aurel32.net ([88.191.82.174]:51015) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OFUun-0002K0-Pi for qemu-devel@nongnu.org; Fri, 21 May 2010 12:17:37 -0400 Date: Fri, 21 May 2010 18:17:36 +0200 From: Aurelien Jarno Subject: Re: [Qemu-devel] Re: lsi: Handle removal of selected devices Message-ID: <20100521161736.GA27745@hall.aurel32.net> References: <20100521154926.GA22706@hall.aurel32.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20100521154926.GA22706@hall.aurel32.net> Sender: Aurelien Jarno List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: qemu-devel@nongnu.org On Fri, May 21, 2010 at 05:49:26PM +0200, Aurelien Jarno wrote: > This patch: > > 64d564094cac5f72eeaeb950c442b773a00d3586 is the first bad commit > commit 64d564094cac5f72eeaeb950c442b773a00d3586 > Author: Jan Kiszka > Date: Tue May 4 14:21:03 2010 +0200 > > lsi: Handle removal of selected devices > > We must not store references to selected devices as they may be > hot-removed. Instead, look up the device based on its tag right before > using it. If the device disappeared, throw an interrupt and disconnect. > > Signed-off-by: Jan Kiszka > Signed-off-by: Anthony Liguori > > breaks the versatile machine. qemu-system-arm segfaults during the boot. Actually it only seems to be the case with old kernels. I have put the material to reproduce the bug here: http://temp.aurel32.net/qemu-versatile/ -- Aurelien Jarno GPG: 1024D/F1BCDB73 aurelien@aurel32.net http://www.aurel32.net