From: Wolfgang Denk Date: Fri, 21 May 2010 21:52:33 +0200 Subject: [U-Boot] [PATCH] Move ICS CLK chip frequenty calculation code into a common board library In-Reply-To: References: <1274433495-31885-1-git-send-email-galak@kernel.crashing.org> Message-ID: <20100521195233.A5156CCF026@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Timur Tabi, In message you wrote: > > So here's a better version of that function that rounds to the nearest > MHz and is of a proper coding style: Why do we need that? > And the result: > > Clock Configuration: > CPU0:800 MHz, CPU1:800 MHz, > CCB:400 MHz, > DDR:300 MHz (600 MT/s data rate) (Asynchronous), LBC:25 MHz The result looks ugly (why do we have double spaces after the numbers?, why do the numbers not align vertically?). This makes me wonder why you use a "%-4s" format in arch/powerpc/cpu/mpc8?xx/cpu.c - may I recommend changing this into "%s" (if you don't care about vertical alignment), or something like "%4s" else? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de It is surely a great calamity for a human being to have no ob- sessions. - Robert Bly