From: Wolfgang Denk Date: Sat, 22 May 2010 00:29:47 +0200 Subject: [U-Boot] [PATCH] Move ICS CLK chip frequenty calculation code into a common board library In-Reply-To: References: <1274433495-31885-1-git-send-email-galak@kernel.crashing.org> Message-ID: <20100521222947.DA6BDCCF026@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Kumar Gala, In message you wrote: > > >> +{ > >> + const unsigned long input_freq = CONFIG_ICS307_REFCLK_HZ; > >> + unsigned long VDW = ((cw1 << 1) & 0x1FE) + ((cw2 >> 7) & 1); > >> + unsigned long RDW = cw2 & 0x7F; > >> + unsigned long OD = ics307_s_to_od[cw0 & 0x7]; > >> + unsigned long freq; > > > > Wolfgang just asked me not to use camel caps. > > where are there camel caps? There aren't. But we do not allow for ALLCAPS identifiers either (these are reserved for macro names). Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Behind every great man, there is a woman -- urging him on. -- Harry Mudd, "I, Mudd", stardate 4513.3