From: Kenneth Graunke Subject: Re: [PATCH 2/2] drm/i915: add power monitoring support Date: Fri, 21 May 2010 23:55:43 -0700 Message-ID: <201005212355.43400.kenneth@whitecape.org> References: <20100520142723.01c217d0@virtuousgeek.org> <20100520142811.314a5e80@virtuousgeek.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from hapkido.dreamhost.com (hapkido.dreamhost.com [66.33.216.122]) by gabe.freedesktop.org (Postfix) with ESMTP id B3BD79E79C for ; Sat, 22 May 2010 00:00:13 -0700 (PDT) Received: from homiemail-a1.g.dreamhost.com (caiajhbdcaid.dreamhost.com [208.97.132.83]) by hapkido.dreamhost.com (Postfix) with ESMTP id 05B7817D77B for ; Fri, 21 May 2010 23:54:26 -0700 (PDT) In-Reply-To: <20100520142811.314a5e80@virtuousgeek.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Jesse Barnes Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Jesse, This patch seems to have a lot of magical numbers in it. In particular, v_table and cparams both seem rather cryptic. Would it be possible to add a few comments saying what these numbers mean or where they came from? Thanks, --Kenneth