From: Jeff Layton Subject: Re: [PATCH 1/4] cifs: make cifs_lookup return a dentry Date: Sat, 22 May 2010 10:08:36 -0400 Message-ID: <20100522100836.28b95cff@tlielax.poochiereds.net> References: <1274466317-28231-1-git-send-email-jlayton@redhat.com> <1274466317-28231-2-git-send-email-jlayton@redhat.com> <20100522133051.GL31073@ZenIV.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: linux-cifs-client@lists.samba.org, linux-fsdevel@vger.kernel.org To: Al Viro Return-path: Received: from mx1.redhat.com ([209.132.183.28]:62861 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753142Ab0EVOIk (ORCPT ); Sat, 22 May 2010 10:08:40 -0400 In-Reply-To: <20100522133051.GL31073@ZenIV.linux.org.uk> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Sat, 22 May 2010 14:30:51 +0100 Al Viro wrote: > On Fri, May 21, 2010 at 02:25:14PM -0400, Jeff Layton wrote: > > cifs_lookup doesn't actually return a dentry. It instantiates the one > > that's passed in, but callers don't have any way to know if the lookup > > succeeded. > > Huh? Of course they do - ->lookup() has every right to do just that; > d_add() and return NULL is perfectly legitimate. OK, bad description on my part... Is one way of doing this preferred over another? -- Jeff Layton