From: Wolfgang Denk Date: Wed, 26 May 2010 21:14:49 +0200 Subject: [U-Boot] libfdt: make fdt_increase_size() available to everyone In-Reply-To: <4BFD6704.2040800@freescale.com> References: <20100519151402.9066DE6D663@gemini.denx.de> <4BF4051A.1090202@freescale.com> <20100525175052.2982FE22AD1@gemini.denx.de> <4BFC1075.5010508@freescale.com> <20100525191502.33B97E524DE@gemini.denx.de> <4BFC24DB.8070805@freescale.com> <20100525221102.DE77BEAC238@gemini.denx.de> <4BFD3A39.4090209@freescale.com> <20100526161122.BA7C1EAC238@gemini.denx.de> <4BFD4E83.2080202@freescale.com> <20100526172312.GA4057@schlenkerla.am.freescale.net> <4BFD60CB.5000806@freescale.com> <4BFD631F.2030401@freescale.com> <4BFD6704.2040800@freescale.com> Message-ID: <20100526191449.A171BEAC238@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Timur Tabi, In message <4BFD6704.2040800@freescale.com> you wrote: > > We have something like that already: > > #ifndef CONFIG_SYS_FDT_PAD > #define CONFIG_SYS_FDT_PAD 0x3000 > #endif > > And Wolfgang doesn't like it. Because nobody can explain where this magic number 0x3000 is coming from or why it is supposed to be sufficient. > I was going to do this in my board header file: > > #define CONFIG_SYS_MAX_QE_FW_SIZE 0x4000 And I rejected this because it is pecific to just one use case (QE support) while I want a generic solution. Also, compile time size limits are always a bad thing if we can have run-time computed limits instead. > Are you suggesting that we implement some user interface where the user, on > the command line, can specify any number and type of firmware binaries to > get embedded in the device tree? No. Such information should be part of the firmware image itself. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Documentation is the castor oil of programming. Managers know it must be good because the programmers hate it so much.