From: Wolfgang Denk Date: Wed, 26 May 2010 23:00:21 +0200 Subject: [U-Boot] [PATCH 05/17] LEON3: added memory controller initialization using the new AMBA PnP routines. In-Reply-To: <1274194143-8994-4-git-send-email-daniel@gaisler.com> References: <1274194143-8994-1-git-send-email-daniel@gaisler.com> <1274194143-8994-4-git-send-email-daniel@gaisler.com> Message-ID: <20100526210021.C687CEAC238@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Daniel Hellstrom, In message <1274194143-8994-4-git-send-email-daniel@gaisler.com> you wrote: > Signed-off-by: Daniel Hellstrom > --- > arch/sparc/cpu/leon3/Makefile | 5 +- > arch/sparc/cpu/leon3/memcfg.c | 276 +++++++++++++++++++++++++++++++++++++ > arch/sparc/cpu/leon3/memcfg.h | 106 ++++++++++++++ > arch/sparc/cpu/leon3/memcfg_low.S | 270 ++++++++++++++++++++++++++++++++++++ > arch/sparc/cpu/leon3/start.S | 36 +++++ > include/configs/gr_cpci_ax2000.h | 27 ++-- > include/configs/gr_ep2s60.h | 32 +++-- > include/configs/gr_xc3s_1500.h | 23 ++-- > include/configs/grsim.h | 27 ++-- > 9 files changed, 754 insertions(+), 48 deletions(-) > create mode 100644 arch/sparc/cpu/leon3/memcfg.c > create mode 100644 arch/sparc/cpu/leon3/memcfg.h > create mode 100644 arch/sparc/cpu/leon3/memcfg_low.S > > diff --git a/arch/sparc/cpu/leon3/Makefile b/arch/sparc/cpu/leon3/Makefile > index d8f89bc..f1bb808 100644 > --- a/arch/sparc/cpu/leon3/Makefile > +++ b/arch/sparc/cpu/leon3/Makefile > @@ -26,8 +26,9 @@ include $(TOPDIR)/config.mk > LIB = $(obj)lib$(CPU).a > > START = start.o > -SOBJS = ambapp_low.o ambapp_low_c.o > -COBJS = cpu_init.o serial.o cpu.o ambapp.o interrupts.o prom.o usb_uhci.o > +SOBJS = ambapp_low.o ambapp_low_c.o memcfg_low.o > +COBJS = cpu_init.o serial.o cpu.o ambapp.o interrupts.o prom.o usb_uhci.o \ > + memcfg.o Please sort lists. > SRCS := $(START:.o=.S) $(SOBJS:.o=.S) $(COBJS:.o=.c) > OBJS := $(addprefix $(obj),$(SOBJS) $(COBJS)) > diff --git a/arch/sparc/cpu/leon3/memcfg.c b/arch/sparc/cpu/leon3/memcfg.c > new file mode 100644 > index 0000000..4a9bded > --- /dev/null > +++ b/arch/sparc/cpu/leon3/memcfg.c > @@ -0,0 +1,276 @@ > +/* GRLIB Memory controller setup. The register values are used > + * from the associated low level assembler routine implemented > + * in memcfg_low.S. Please apply all review comments to the previous patch here, too (white space, multiline comment style, brace style, etc.) Ditto for your other patches. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Vor allem kein Gedanke! Nichts ist kompromittierender als ein Gedan- ke! - Friedrich Wilhelm Nietzsche _Der Fall Wagner_ (1888)