From: Al Viro Subject: Re: [PATCHv4 17/17] writeback: lessen sync_supers wakeup count Date: Thu, 27 May 2010 10:08:59 +0100 Message-ID: <20100527090859.GB31073@ZenIV.linux.org.uk> References: <1274795352-3551-1-git-send-email-dedekind1@gmail.com> <1274795352-3551-18-git-send-email-dedekind1@gmail.com> <20100527065041.GA31073@ZenIV.linux.org.uk> <20100527072240.GM22536@laptop> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Artem Bityutskiy , LKML , Jens Axboe , linux-fsdevel@vger.kernel.org To: Nick Piggin Return-path: Content-Disposition: inline In-Reply-To: <20100527072240.GM22536@laptop> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Thu, May 27, 2010 at 05:22:40PM +1000, Nick Piggin wrote: > Yeah, we definitely don't want to add global cacheline writes in the > common case. Also I don't know why you do the strange -1 value. I > couldn't seem to find where you defined bdi_arm_supers_timer(); bdi_arm_supers_timer() is in the mainline; basically, it's "schedule timer that'll wake sync_supers_tsk in $INTERVAL from now".