From: Jesse Barnes Subject: Re: [PATCH] drm/i915: use wake_up instead of drm wrapper. Date: Fri, 28 May 2010 09:05:01 -0700 Message-ID: <20100528090501.129c791c@virtuousgeek.org> References: <1275015728-12954-1-git-send-email-airlied@gmail.com> <20100528091229.GA3612@viiv.ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from outbound-mail-01.bluehost.com (cpoproxy1-pub.bluehost.com [69.89.21.11]) by gabe.freedesktop.org (Postfix) with SMTP id 353989E8B0 for ; Fri, 28 May 2010 09:05:27 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Dave Airlie Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Fri, 28 May 2010 19:55:24 +1000 Dave Airlie wrote: > On Fri, May 28, 2010 at 7:12 PM, Daniel Vetter wrote: > > On Fri, May 28, 2010 at 01:02:08PM +1000, Dave Airlie wrote: > >> This fixes a regression in the copy fb code we use to get seamless > >> startup on Fedora/RHEL, without this fix, we block forever in the wait > >> when starting X. > > > > I've just checked latest -linus and found in include/drm/drm_os_linux.h: > > > > #define DRM_WAKEUP( queue ) wake_up( queue ) > > > > It's been like that since I've originally wrote the uninterruptible sleep > > stuff for the intel overlay code (I've checked way back then to make sure > > it doesn't hang). Care to explain how this fixes a regression? > > > > doh, you fixed that in the patch, and for some reason we don't have > that in our Fedora or RHEL backports wierd. > > Ignore this. > > I don't remember much discussion on changing drm_os_linux, but it > should have been fine. We should still kill the drm_os_linux bits where possible... -- Jesse Barnes, Intel Open Source Technology Center