From: Daniel Vetter Subject: Re: [PATCH] drm/i915: use wake_up instead of drm wrapper. Date: Fri, 28 May 2010 11:12:30 +0200 Message-ID: <20100528091229.GA3612@viiv.ffwll.ch> References: <1275015728-12954-1-git-send-email-airlied@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail.ffwll.ch (cable-static-49-187.intergga.ch [157.161.49.187]) by gabe.freedesktop.org (Postfix) with ESMTP id B288C9ED9D for ; Fri, 28 May 2010 02:11:39 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1275015728-12954-1-git-send-email-airlied@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Dave Airlie Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Fri, May 28, 2010 at 01:02:08PM +1000, Dave Airlie wrote: > This fixes a regression in the copy fb code we use to get seamless > startup on Fedora/RHEL, without this fix, we block forever in the wait > when starting X. I've just checked latest -linus and found in include/drm/drm_os_linux.h: #define DRM_WAKEUP( queue ) wake_up( queue ) It's been like that since I've originally wrote the uninterruptible sleep stuff for the intel overlay code (I've checked way back then to make sure it doesn't hang). Care to explain how this fixes a regression? Cheers, Daniel -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48