From: Jan Kara Subject: Re: [PATCH 1/6] sort out blockdev_direct_IO variants Date: Wed, 2 Jun 2010 01:16:26 +0200 Message-ID: <20100601231626.GE8137@quack.suse.cz> References: <20100530204932.GA21002@lst.de> <20100530204942.GB21002@lst.de> <20100601230014.GC8137@quack.suse.cz> <20100601231202.GA32382@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Jan Kara , viro@zeniv.linux.org.uk, npiggin@suse.de, linux-fsdevel@vger.kernel.org, chris.mason@oracle.com To: Christoph Hellwig Return-path: Received: from cantor2.suse.de ([195.135.220.15]:39308 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755940Ab0FAXQl (ORCPT ); Tue, 1 Jun 2010 19:16:41 -0400 Content-Disposition: inline In-Reply-To: <20100601231202.GA32382@lst.de> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Wed 02-06-10 01:12:02, Christoph Hellwig wrote: > On Wed, Jun 02, 2010 at 01:00:14AM +0200, Jan Kara wrote: > > On Sun 30-05-10 22:49:42, Christoph Hellwig wrote: > > > Move the call to vmtruncate to get rid of accessive blocks to the callers > > > in prepearation of the new truncate calling sequence. This was only done > > > for DIO_LOCKING filesystems, so the __blockdev_direct_IO_newtrunc variant > > > was not needed anyway. Get rid of blockdev_direct_IO_no_locking and > > > it's _newtrunc variant while at it as just opencoding the two additional > > > paramters is shorted than the name suffix. > > Hmm, I've noticed that you didn't add truncate code to btrfs. I see that > > it already does some recovery after direct IO error but I'd like to make > > sure that it won't be broken by your patches... Chris? > > As mentioned above __blockdev_direct_IO only called vmtruncate for the > DIO_LOCKING, which does not include btrfs. And yes, there's quite a bit > of things that need cleanup but didn't have it before due to the way > the cleanup code was hidden, but that's not something I want to do > in this transformation series. Ah, OK. I forgot about that DIO_LOCKING thing. Thanks for clarification. Honza -- Jan Kara SUSE Labs, CR