From: Masayoshi MIZUMA Subject: [PATCH][BUG] fs: thaw_bdev() should return EINVAL if bd_fsfreeze_count is 0 Date: Wed, 02 Jun 2010 13:50:46 +0900 Message-ID: <20100602135045.4F91.61FB500B@jp.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Cc: linux-fsdevel To: Alexander Viro Return-path: Received: from fgwmail7.fujitsu.co.jp ([192.51.44.37]:53958 "EHLO fgwmail7.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751080Ab0FBEv1 (ORCPT ); Wed, 2 Jun 2010 00:51:27 -0400 Received: from m3.gw.fujitsu.co.jp ([10.0.50.73]) by fgwmail7.fujitsu.co.jp (Fujitsu Gateway) with ESMTP id o524pQ46027539 for (envelope-from m.mizuma@jp.fujitsu.com); Wed, 2 Jun 2010 13:51:26 +0900 Received: from smail (m3 [127.0.0.1]) by outgoing.m3.gw.fujitsu.co.jp (Postfix) with ESMTP id E38C745DE50 for ; Wed, 2 Jun 2010 13:51:25 +0900 (JST) Received: from s3.gw.fujitsu.co.jp (s3.gw.fujitsu.co.jp [10.0.50.93]) by m3.gw.fujitsu.co.jp (Postfix) with ESMTP id C481F45DE4F for ; Wed, 2 Jun 2010 13:51:25 +0900 (JST) Received: from s3.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1]) by s3.gw.fujitsu.co.jp (Postfix) with ESMTP id B168E1DB803E for ; Wed, 2 Jun 2010 13:51:25 +0900 (JST) Received: from m107.s.css.fujitsu.com (m107.s.css.fujitsu.com [10.249.87.107]) by s3.gw.fujitsu.co.jp (Postfix) with ESMTP id 6EB01E18003 for ; Wed, 2 Jun 2010 13:51:22 +0900 (JST) Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Hi, thaw_bdev() should return EINVAL if bd_fsfreeze_count is 0 at entering thaw_bdev() because it is expected that bd_fsfreeze_count is incremented by freeze_bdev(). This bug was added by commit:4504230a71566785a05d3e6b53fa1ee071b864eb Signed-off-by: Masayoshi MIZUMA --- fs/block_dev.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/block_dev.c b/fs/block_dev.c index 6dcee88..90992b3 100644 --- a/fs/block_dev.c +++ b/fs/block_dev.c @@ -331,7 +331,7 @@ out_unfrozen: deactivate_locked_super(sb); out_unlock: mutex_unlock(&bdev->bd_fsfreeze_mutex); - return 0; + return error; } EXPORT_SYMBOL(thaw_bdev); -- 1.6.6 Thanks, Masayoshi