From: broonie@opensource.wolfsonmicro.com (Mark Brown)
Date: Mon, 7 Jun 2010 12:48:56 +0100
Subject: [PATCH 1/2] ISL6271A voltage regulator support.
In-Reply-To: <1275887908-22285-1-git-send-email-marek.vasut@gmail.com>
References: <1275887908-22285-1-git-send-email-marek.vasut@gmail.com>
Message-ID: <20100607114856.GD5993@sirena.org.uk>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org

On Mon, Jun 07, 2010 at 07:18:27AM +0200, Marek Vasut wrote:

> This device is very simple, it supports only one LDO. This single LDO is
> programmed over I2C to 16 possible voltages.

Marek, you really should know to CC patches to maintainers by now.  This
is not CCed to myself, Liam or lkml.

> +#include <linux/regulator/driver.h>
> +#include <linux/regulator/machine.h>

Why are you including machine.h here?  I can't actually see any suspect
code in the driver so I suspect it's unused.

Otherwise this looks good.