Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1OLff7-00017q-Be for mharc-grub-devel@gnu.org; Mon, 07 Jun 2010 12:58:57 -0400 Received: from [140.186.70.92] (port=37688 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OLfez-000138-AR for grub-devel@gnu.org; Mon, 07 Jun 2010 12:58:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OLfew-0004m7-Uv for grub-devel@gnu.org; Mon, 07 Jun 2010 12:58:48 -0400 Received: from smarthost01.mail.zen.net.uk ([212.23.3.140]:34599) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OLfew-0004lj-Lj for grub-devel@gnu.org; Mon, 07 Jun 2010 12:58:46 -0400 Received: from [82.69.40.219] (helo=riva.pelham.vpn.ucam.org) by smarthost01.mail.zen.net.uk with esmtp (Exim 4.63) (envelope-from ) id 1OLfeu-0004H7-Ke for grub-devel@gnu.org; Mon, 07 Jun 2010 16:58:44 +0000 Received: from cjwatson by riva.pelham.vpn.ucam.org with local (Exim 3.36 #1 (Debian)) for grub-devel@gnu.org id 1OLfet-0000QW-00; Mon, 07 Jun 2010 17:58:43 +0100 Date: Mon, 7 Jun 2010 17:58:43 +0100 From: Colin Watson To: grub-devel@gnu.org Message-ID: <20100607165842.GL21862@riva.ucam.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.18 (2008-05-17) X-Originating-Smarthost01-IP: [82.69.40.219] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: [PATCH] (pxe:server_ip:gateway_ip) parsing wrong? X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jun 2010 16:58:54 -0000 While writing documentation for booting GRUB over the network, I noticed that the code to handle (pxe:server_ip:gateway_ip) device names looks wrong. Shouldn't it be like this? 2010-06-07 Colin Watson * fs/i386/pc/pxe.c (grub_pxe_open): Fix parsing of gateway_ip. === modified file 'fs/i386/pc/pxe.c' --- fs/i386/pc/pxe.c 2010-02-14 12:18:33 +0000 +++ fs/i386/pc/pxe.c 2010-06-07 16:56:22 +0000 @@ -114,7 +114,7 @@ grub_pxe_open (const char *name, grub_di return err; if (*ptr == ':') { - err = parse_ip (ptr + 1, &(data->server_ip), 0); + err = parse_ip (ptr + 1, &(data->gateway_ip), 0); if (err) return err; } Thanks, -- Colin Watson [cjwatson@ubuntu.com]