From: Mike Frysinger Date: Mon, 7 Jun 2010 18:49:27 -0400 Subject: [U-Boot] [PATCH] [v2] tsec: fix the return value for tsec_eth_init() and tsec_standard_init() In-Reply-To: <1275935487-2031-1-git-send-email-timur@freescale.com> References: <1275935487-2031-1-git-send-email-timur@freescale.com> Message-ID: <201006071849.29511.vapier@gentoo.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Monday, June 07, 2010 14:31:27 Timur Tabi wrote: > In general, if an function initializes only one device, then it should > return a negative number if there's an error. If it initializes more than > one device, then it should never return a negative number. This is why > these functions now return an unsigned integer. i dont think this is a good idea. either the init funcs should all be converted to unsigned int, or they should stay int. doing it piecemeal leads to confusion with zero upside. your fixes no way require these to be unsigned int funcs. -mike -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: This is a digitally signed message part. Url : http://lists.denx.de/pipermail/u-boot/attachments/20100607/6f33d0ff/attachment.pgp