Resent-Message-ID: <20100612122103.GA1390@ohm.aurel32.net>
Resent-To: jan.kiszka@web.de, pbonzini@redhat.com, qemu-devel@nongnu.org
Date: Sat, 12 Jun 2010 13:55:57 +0200
From: Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH] configure: Fix evaluation of
	config-host.mak in create_config
Message-ID: <20100612115557.GK3008@ohm.aurel32.net>
References: <4C12A375.6050201@web.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Content-Disposition: inline
In-Reply-To: <4C12A375.6050201@web.de>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel <qemu-devel@nongnu.org>

On Fri, Jun 11, 2010 at 10:58:29PM +0200, Jan Kiszka wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
> 
> Only match on true dir variable assignments, avoid generating garbage
> due to the "# Configured with: ..." line which may contain "*dir=" as
> well.

Wouldn't it be better to skip all lines starting with '#', as this
problem might happen again after some more changes?

Or maybe we should do both.

> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>  create_config |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/create_config b/create_config
> index 23c0cd5..0098e68 100755
> --- a/create_config
> +++ b/create_config
> @@ -13,7 +13,7 @@ case $line in
>      pkgversion=${line#*=}
>      echo "#define QEMU_PKGVERSION \"$pkgversion\""
>      ;;
> - prefix=* | *dir=*) # directory configuration
> + prefix=* | [a-z]*dir=*) # directory configuration
>      name=${line%=*}
>      value=${line#*=}
>      define_name=`echo $name | tr '[:lower:]' '[:upper:]'`
> 
> 

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net