From: Christoph Egger <Christoph.Egger@amd.com>
Subject: Re: [PATCH] svm: debug improvements
Date: Thu, 24 Jun 2010 12:33:16 +0200
Message-ID: <201006241233.16923.Christoph.Egger@amd.com>
References: <C847CF3C.184AB%keir.fraser@eu.citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <C847CF3C.184AB%keir.fraser@eu.citrix.com>
Content-Disposition: inline
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: xen-devel@lists.xensource.com
Cc: Keir Fraser <keir.fraser@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

On Wednesday 23 June 2010 15:48:28 Keir Fraser wrote:
> On 23/06/2010 13:49, "Christoph Egger" <Christoph.Egger@amd.com> wrote:
> > Attached patch moves vmcb dump function into
> > its own svm debug files.
> > Add svm_vmcb_isvalid() to svm code to validate
> > the vmcb.
>
> I won't take patches to add things that aren't used. Unless they are used
> later in the same patch series,

Yes, that is the case. It will be used in the nested virtualization patch 
series. Do you prefer me to resend it as part of the patch series?

> all posted with intention to be applied at 
> the same time. Otherwise the function is dead code, and I love to delete
> dead code.

Me, too.

Christoph

-- 
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632