From: Wolfgang Denk Date: Tue, 29 Jun 2010 09:52:00 +0200 Subject: [U-Boot] [PATCH v2] ppc4xx: Add T3COPR board support (PPC460GT based) In-Reply-To: <1277796281-19728-1-git-send-email-sr@denx.de> References: <1277796281-19728-1-git-send-email-sr@denx.de> Message-ID: <20100629075200.5AD4B1524EC@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Stefan Roese, In message <1277796281-19728-1-git-send-email-sr@denx.de> you wrote: > This patch adds support for the T3CORP board, based on the > AppliedMicro (AMCC) PPC460GT. General question: should we rename "amcc" into "apm" ? ... > +int board_early_init_r(void) > +{ ... > + /* Add TLB entry for 0xfn00.0000 -> 0x4.cn00.0000 */ > + program_tlb(CONFIG_SYS_FLASH_BASE_PHYS, CONFIG_SYS_FLASH_BASE, > + CONFIG_SYS_FLASH_SIZE, TLB_WORD2_I_ENABLE); > + > + /* > + * Now accessing of the whole 64Mbytes of NOR FLASH at virtual address > + * 0xfc00.0000 is possible > + */ What about the configuration with 128 MiB NOR flash? Would it not be more flexible to use something like program_tlb(CONFIG_SYS_FLASH_END_PHYS-flash_info[0].size, -flash_info[0].size, flash_info[0].size, TLB_WORD2_I_ENABLE); with CONFIG_SYS_FLASH_END_PHYS_H = 0x4 and CONFIG_SYS_FLASH_END_PHYS_L = 0xD0000000 ? BTW: Please use "flash" (globally) instead of FLASH - "flash" is not an abbreviation. > +int board_pcie_last(void) > +{ > + /* > + * Only PCIe0 for now, PCIe1 hangs on this boards "on this board" or "on these boards" Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Lots of people drink from the wrong bottle sometimes. -- Edith Keeler, "The City on the Edge of Forever", stardate unknown