Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1OUeVz-000132-H5 for mharc-grub-devel@gnu.org; Fri, 02 Jul 2010 07:34:39 -0400 Received: from [140.186.70.92] (port=45212 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OUeVv-00010M-0n for grub-devel@gnu.org; Fri, 02 Jul 2010 07:34:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OUeVt-0004MG-S0 for grub-devel@gnu.org; Fri, 02 Jul 2010 07:34:34 -0400 Received: from smarthost02.mail.zen.net.uk ([212.23.3.141]:50104) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OUeVt-0004M4-L2 for grub-devel@gnu.org; Fri, 02 Jul 2010 07:34:33 -0400 Received: from [82.69.40.219] (helo=riva.pelham.vpn.ucam.org) by smarthost02.mail.zen.net.uk with esmtp (Exim 4.63) (envelope-from ) id 1OUeVs-0005yw-As for grub-devel@gnu.org; Fri, 02 Jul 2010 11:34:32 +0000 Received: from cjwatson by riva.pelham.vpn.ucam.org with local (Exim 3.36 #1 (Debian)) for grub-devel@gnu.org id 1OUeVr-0002ox-00; Fri, 02 Jul 2010 12:34:31 +0100 Date: Fri, 2 Jul 2010 12:34:31 +0100 From: Colin Watson To: The development of GNU GRUB Message-ID: <20100702113430.GV21862@riva.ucam.org> References: <20100602190744.GA4058@rangda.stickybit.se> <4C2D07AC.6020006@gmail.com> <20100701233226.GU21862@riva.ucam.org> <4C2D2855.2020707@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <4C2D2855.2020707@gmail.com> User-Agent: Mutt/1.5.18 (2008-05-17) X-Originating-Smarthost02-IP: [82.69.40.219] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: Re: [PATCH] Fix root device detection for lvm2 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Jul 2010 11:34:37 -0000 On Fri, Jul 02, 2010 at 01:44:21AM +0200, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > On 07/02/2010 01:32 AM, Colin Watson wrote: > > The changes seem to have been to simplify the test to: > > > > [ "x`grub-probe -t abstraction --device ${GRUB_DEVICE}`" = "xlvm" ] > > > > Unfortunately this is an incorrect simplification. grub-probe can print > > multiple abstractions, and does in the case of e.g. LVM on RAID. If it > > is correct to avoid UUIDs for plain LVM, it is also correct to avoid > > them for LVM on RAID. > > Ok I agree. The problem with original patch was that it would accept > ttttlvmuuu too. Feel free to fix. Fair enough. Done (r2503). -- Colin Watson [cjwatson@ubuntu.com]