Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1OWBOJ-0000rI-1j for mharc-grub-devel@gnu.org; Tue, 06 Jul 2010 12:53:03 -0400 Received: from [140.186.70.92] (port=35188 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OWBOF-0000pl-00 for grub-devel@gnu.org; Tue, 06 Jul 2010 12:53:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OWBOC-0004yn-R8 for grub-devel@gnu.org; Tue, 06 Jul 2010 12:52:58 -0400 Received: from smarthost02.mail.zen.net.uk ([212.23.3.141]:54535) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OWBOC-0004ya-Jb for grub-devel@gnu.org; Tue, 06 Jul 2010 12:52:56 -0400 Received: from [82.69.40.219] (helo=riva.pelham.vpn.ucam.org) by smarthost02.mail.zen.net.uk with esmtp (Exim 4.63) (envelope-from ) id 1OWBOA-0003NX-FO for grub-devel@gnu.org; Tue, 06 Jul 2010 16:52:54 +0000 Received: from cjwatson by riva.pelham.vpn.ucam.org with local (Exim 3.36 #1 (Debian)) for grub-devel@gnu.org id 1OWBOA-0000Do-00; Tue, 06 Jul 2010 17:52:54 +0100 Date: Tue, 6 Jul 2010 17:52:53 +0100 From: Colin Watson To: grub-devel@gnu.org Message-ID: <20100706165253.GP21862@riva.ucam.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.18 (2008-05-17) X-Originating-Smarthost02-IP: [82.69.40.219] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: [PATCH] Add raid5rec and raid6rec to grub-probe and grub-setup X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Jul 2010 16:53:00 -0000 Martin F. Krafft showed up on IRC with a problem that turned out to be mainly due to running on a degraded RAID array, which grub-probe and grub-setup were unable to handle because they didn't have the necessary modules built in. (He has some other problem after that which I haven't yet managed to track down.) Is there any reason not to include RAID recovery support in grub-probe and grub-setup? It's already in grub-fstest, including it at least makes GRUB installable for Martin, and I don't see any commits that explicitly removed this support at any point so there doesn't seem to be any particular reason they aren't included. 2010-07-06 Colin Watson * conf/common.rmk (grub_probe_SOURCES): Add disk/raid5_recover.c and disk/raid6_recover.c. * conf/i386-pc.rmk (grub_setup_SOURCES): Likewise. * conf/sparc64-ieee1275.rmk (grub_setup_SOURCES): Likewise. === modified file 'conf/common.rmk' --- conf/common.rmk 2010-07-02 17:35:07 +0000 +++ conf/common.rmk 2010-07-06 14:03:50 +0000 @@ -38,7 +38,8 @@ grub_probe_SOURCES = gnulib/progname.c u partmap/msdos.c partmap/bsdlabel.c partmap/apple.c \ partmap/sun.c partmap/sunpc.c partmap/gpt.c \ kern/fs.c kern/env.c fs/fshelp.c \ - disk/raid.c disk/mdraid_linux.c disk/lvm.c grub_probe_init.c + disk/raid.c disk/raid5_recover.c disk/raid6_recover.c \ + disk/mdraid_linux.c disk/lvm.c grub_probe_init.c ifeq ($(enable_grub_fstest), yes) bin_UTILITIES += grub-fstest === modified file 'conf/i386-pc.rmk' --- conf/i386-pc.rmk 2010-06-12 11:17:28 +0000 +++ conf/i386-pc.rmk 2010-07-06 14:04:13 +0000 @@ -78,7 +78,8 @@ grub_setup_SOURCES = gnulib/progname.c u partmap/msdos.c partmap/bsdlabel.c partmap/sunpc.c \ partmap/gpt.c \ \ - disk/raid.c disk/mdraid_linux.c disk/lvm.c \ + disk/raid.c disk/raid5_recover.c disk/raid6_recover.c \ + disk/mdraid_linux.c disk/lvm.c \ util/raid.c util/lvm.c \ grub_setup_init.c === modified file 'conf/sparc64-ieee1275.rmk' --- conf/sparc64-ieee1275.rmk 2010-07-02 17:35:07 +0000 +++ conf/sparc64-ieee1275.rmk 2010-07-06 14:04:29 +0000 @@ -62,7 +62,8 @@ grub_setup_SOURCES = util/sparc64/ieee12 partmap/amiga.c partmap/apple.c partmap/msdos.c \ partmap/bsdlabel.c partmap/sun.c partmap/acorn.c \ \ - disk/raid.c disk/mdraid_linux.c disk/lvm.c util/raid.c \ + disk/raid.c disk/raid5_recover.c disk/raid6_recover.c \ + disk/mdraid_linux.c disk/lvm.c util/raid.c \ util/lvm.c gnulib/progname.c grub_setup_init.c # For grub-ofpathname. Thanks, -- Colin Watson [cjwatson@ubuntu.com]