From: Jesse Barnes Subject: Re: drm/i915: don't change DRM configuration when releasing load detect pipe Date: Fri, 9 Jul 2010 08:30:11 -0700 Message-ID: <20100709083011.4fc2dc6f@virtuousgeek.org> References: <20100218145154.7aa7d557@jbarnes-piketon> <87iq9pb5ab.fsf@pollan.anholt.net> <4B956531.3000901@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from cpoproxy2-pub.bluehost.com (cpoproxy2-pub.bluehost.com [67.222.39.38]) by gabe.freedesktop.org (Postfix) with SMTP id 9EFCF9E799 for ; Fri, 9 Jul 2010 08:30:36 -0700 (PDT) In-Reply-To: <4B956531.3000901@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Brice Goglin Cc: airlied@linux.ie, intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Mon, 08 Mar 2010 21:59:29 +0100 Brice Goglin wrote: > Eric Anholt wrote: > > On Thu, 18 Feb 2010 14:51:54 -0800, Jesse Barnes wrote: > > > >> When we get a CRTC to use for load detection, we restore its DPMS state > >> if needed. We shouldn't, however, change the DRM configuration by > >> calling drm_helper_disable_unused_functions when we release the CRTC. > >> Doing so can cause problems with resume, since at suspend or lid close > >> time, X may choose to probe outputs. If it doesn't re-probe them at > >> open or resume time, LVDS won't be restored, since > >> drm_helper_disable_unused_functions will have turned it off, preventing > >> the mode set at lid open from restoring it. > >> > > > > It seems to me like the bug is that drm_helper_disable_unused_functions > > whacks the configuration. Why should it do that? > > > > if (connector->status == connector_status_disconnected) > > connector->encoder = NULL; > > > > This function back in UMS used to be about getting the system from > > unknown bootup state to other junk being turned off after the initial > > modeset (which was of course broken, since having the other junk turned > > on during modeset could break things, so really it should have been > > intel_turn_everything_off_thanks() before doing a modeset). > > > > Once that's fixed, it seems like it'd be a replacement for the > > turn-off-after-load-detect logic in the load detect pipe release > > function. > > > > Did anything get applied to fix this issue in the end ? Jesse's initial > patch fixed blank screens on my i 945 so I am still applying it to my > kernels for now. Arg, totally dropped this one. Dave, please comment on the above. -- Jesse Barnes, Intel Open Source Technology Center