From: Wolfgang Denk <wd@denx.de>
Date: Wed, 14 Jul 2010 23:43:17 +0200
Subject: [U-Boot] [PATCH] powerpc/85xx: Add command to report errata
	workarounds
In-Reply-To: <1279142410-30629-1-git-send-email-galak@kernel.crashing.org>
References: <EDA07492-2746-46D4-963A-37F4CAE0B415@kernel.crashing.org>
	<1279142410-30629-1-git-send-email-galak@kernel.crashing.org>
Message-ID: <20100714214317.B26AC160696@gemini.denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Kumar Gala,

In message <1279142410-30629-1-git-send-email-galak@kernel.crashing.org> you wrote:
> Add 'errata' command to report what errata we workaround.  Report
> workaround for erratum SATA-A001 on P1022/P1013.
> 
> Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
...
> +#if defined(CONFIG_FSL_SATA_V2) && defined(CONFIG_FSL_SATA_ERRATUM_A001)
> +	if (IS_SVR_REV(svr, 1, 0)) {
> +		switch (SVR_SOC_VER(svr)) {
> +		case SVR_P1013:
> +		case SVR_P1013_E:
> +		case SVR_P1022:
> +		case SVR_P1022_E:
> +			puts("Work-around for Erratum SATA A001 enabled\n");
> +		}

I think there should be a "default" case?

> +++ b/include/configs/P1022DS.h
> @@ -345,6 +345,7 @@
>  #define CONFIG_CMD_ELF
>  #define CONFIG_CMD_IRQ
>  #define CONFIG_CMD_SETEXPR
> +#define CONFIG_CMD_ERRATA

Please sort the list.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
I really hate this damned machine     It never does quite what I want
I wish that they would sell it.              But only what I tell it.