From: Wolfgang Denk Date: Tue, 20 Jul 2010 15:41:31 +0200 Subject: [U-Boot] [PATCH 1/2] cmd_ide: Convert to [read,write][b,w] In-Reply-To: <1279629934-28674-1-git-send-email-marek.vasut@gmail.com> References: <1279629934-28674-1-git-send-email-marek.vasut@gmail.com> Message-ID: <20100720134131.839A8153780@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Marek Vasut, In message <1279629934-28674-1-git-send-email-marek.vasut@gmail.com> you wrote: > Signed-off-by: Marek Vasut > --- > common/cmd_ide.c | 22 +++++++++++++--------- > 1 files changed, 13 insertions(+), 9 deletions(-) It's not really helpful to resend old patches, without reference and without keeping mail threads in place. Please don't. I tend to reject your patch in favour of Albert Aribaud's one, see http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/81117 Do you have any strong argument why your patch would be better? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Committee, n.: A group of men who individually can do nothing but as a group decide that nothing can be done. - Fred Allen