From: Jesse Barnes Subject: Re: [PATCH] drm/i915: be sure panel is powered up in eDP configs Date: Thu, 22 Jul 2010 13:19:50 -0700 Message-ID: <20100722131950.7c470161@virtuousgeek.org> References: <20100714154056.208b30c9@virtuousgeek.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from cpoproxy1-pub.bluehost.com (cpoproxy1-pub.bluehost.com [69.89.21.11]) by gabe.freedesktop.org (Postfix) with SMTP id EE1B29E7AF for ; Thu, 22 Jul 2010 13:19:37 -0700 (PDT) In-Reply-To: <20100714154056.208b30c9@virtuousgeek.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Wed, 14 Jul 2010 15:40:56 -0700 Jesse Barnes wrote: > Fixes https://bugs.freedesktop.org/show_bug.cgi?id=28739. We need to > enable power to the panel with the AUX VDD bit in order to properly > detect the eDP attached panel, and we also need to turn the panel on in > case it was off when we started (as happens at resume time). > > But this patch raises a couple of questions: > 1) why does the first panel on sequence time out? > 2) why do I need to unlock the panel protected regs? > > Keith, I think this is your code, any ideas? Just posted a more minimal fix and separated out the register patch. Apparently we just need to unlock the panel regs around the actual power on sequence. Talking with the hw guys about this now as there may be a better workaround to the broken panel sequencing logic. -- Jesse Barnes, Intel Open Source Technology Center