From: u.kleine-koenig@pengutronix.de (Uwe =?iso-8859-1?Q?Kleine-K=F6nig?=) Date: Fri, 23 Jul 2010 06:58:07 +0200 Subject: [PATCH] gpio: remove spurious gpio_unexport debug error. In-Reply-To: <1279832758-25442-1-git-send-email-gbean@codeaurora.org> References: <1279832758-25442-1-git-send-email-gbean@codeaurora.org> Message-ID: <20100723045807.GA14875@pengutronix.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hello, On Thu, Jul 22, 2010 at 02:05:58PM -0700, Gregory Bean wrote: > Make gpio_unexport generate success instead of an -EINVAL > if asked to unexport a line which is not exported, because > the only result of that condition is a pr_debug > which complains of what is really a harmless no-op: > when an unexported gpio is unexported again, nothing happens. > That's not a failure, just a trivial border case. > Since gpio_free calls gpio_unexport unconditionally > and exported gpio lines are uncommon, most calls to > gpio_free with debug flags enabled generate -EINVAL > warnings in the log, causing unnecessary stress. I noticed that a few days ago, too. Just didn't come around to fix it myself. > Signed-off-by: Gregory Bean Acked-by: Uwe Kleine-K?nig Thanks Uwe -- Pengutronix e.K. | Uwe Kleine-K?nig | Industrial Linux Solutions | http://www.pengutronix.de/ |