From: Masayoshi MIZUMA Subject: [PATCH] [RESEND] fs: thaw_bdev() should return EINVAL if bd_fsfreeze_count is 0 Date: Tue, 27 Jul 2010 09:12:07 +0900 Message-ID: <20100727091206.4BD8.61FB500B@jp.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Cc: linux-fsdevel@vger.kernel.org To: Alexander Viro Return-path: Received: from fgwmail7.fujitsu.co.jp ([192.51.44.37]:37792 "EHLO fgwmail7.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752877Ab0G0AM0 (ORCPT ); Mon, 26 Jul 2010 20:12:26 -0400 Received: from m2.gw.fujitsu.co.jp ([10.0.50.72]) by fgwmail7.fujitsu.co.jp (Fujitsu Gateway) with ESMTP id o6R0CNKr027291 for (envelope-from m.mizuma@jp.fujitsu.com); Tue, 27 Jul 2010 09:12:24 +0900 Received: from smail (m2 [127.0.0.1]) by outgoing.m2.gw.fujitsu.co.jp (Postfix) with ESMTP id A543345DE5D for ; Tue, 27 Jul 2010 09:12:23 +0900 (JST) Received: from s2.gw.fujitsu.co.jp (s2.gw.fujitsu.co.jp [10.0.50.92]) by m2.gw.fujitsu.co.jp (Postfix) with ESMTP id 7C4E545DE51 for ; Tue, 27 Jul 2010 09:12:23 +0900 (JST) Received: from s2.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1]) by s2.gw.fujitsu.co.jp (Postfix) with ESMTP id 26BDF1DB803F for ; Tue, 27 Jul 2010 09:12:23 +0900 (JST) Received: from ml14.s.css.fujitsu.com (ml14.s.css.fujitsu.com [10.249.87.104]) by s2.gw.fujitsu.co.jp (Postfix) with ESMTP id 824BA1DB8049 for ; Tue, 27 Jul 2010 09:12:22 +0900 (JST) Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Hi, thaw_bdev() should return EINVAL if bd_fsfreeze_count is 0 at entering thaw_bdev() because it is expected that bd_fsfreeze_count is incremented by freeze_bdev(). Signed-off-by: Masayoshi MIZUMA --- fs/block_dev.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/block_dev.c b/fs/block_dev.c index 99d6af8..51500f6 100644 --- a/fs/block_dev.c +++ b/fs/block_dev.c @@ -291,7 +291,7 @@ int thaw_bdev(struct block_device *bdev, struct super_block *sb) } out: mutex_unlock(&bdev->bd_fsfreeze_mutex); - return 0; + return error; } EXPORT_SYMBOL(thaw_bdev); -- 1.6.2.5 Thanks, Masayoshi