From: Wolfgang Denk Date: Tue, 03 Aug 2010 23:16:17 +0200 Subject: [U-Boot] [PATCH 7/7] PXA: Vpac270 config fixes In-Reply-To: <1279811005-21858-7-git-send-email-marek.vasut@gmail.com> References: <1279811005-21858-1-git-send-email-marek.vasut@gmail.com> <1279811005-21858-7-git-send-email-marek.vasut@gmail.com> Message-ID: <20100803211617.1C86D28F@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Marek Vasut, In message <1279811005-21858-7-git-send-email-marek.vasut@gmail.com> you wrote: > Define __io to get harddrive working. > Fix saving of environment into OneNAND. > Boot from harddrive when possible. > > Signed-off-by: Marek Vasut > --- > include/configs/vpac270.h | 12 +++++++++++- > 1 files changed, 11 insertions(+), 1 deletions(-) > > diff --git a/include/configs/vpac270.h b/include/configs/vpac270.h > index 6d02995..a0383b2 100644 > --- a/include/configs/vpac270.h > +++ b/include/configs/vpac270.h > @@ -36,7 +36,7 @@ > /* > * Environment settings > */ > -#define CONFIG_ENV_SIZE 0x4000 > +#define CONFIG_ENV_SIZE 0x20000 Do you really need 128 KiB for environment data? [Note that this is NOT a sector size or so!] Really??? I think this is not true. > +/* > + * HACK WARNING: __io > + * This MUST go away once the readb/writeb and inb/outb issue is solved > + */ > +#define __io Drop that. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de "Plan to throw one away. You will anyway." - Fred Brooks, "The Mythical Man Month"