From: Jesse Barnes Subject: Re: [PATCH 2/2] drm/i915: Fix offset page-flips on i965+ Date: Wed, 11 Aug 2010 08:18:57 -0700 Message-ID: <20100811081857.5bbf82c6@virtuousgeek.org> References: <20100810143753.2c6f6f8e@virtuousgeek.org> <1281518747-5085-2-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from cpoproxy2-pub.bluehost.com (cpoproxy2-pub.bluehost.com [67.222.39.38]) by gabe.freedesktop.org (Postfix) with SMTP id F26069E7B1 for ; Wed, 11 Aug 2010 08:18:59 -0700 (PDT) In-Reply-To: <1281518747-5085-2-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Wed, 11 Aug 2010 10:25:47 +0100 Chris Wilson wrote: > i965 uses the Display Registers to compute the offset from the display > base so the new base does not need adjusting when flipping. The older > chipsets use a fence to access the display and so do perceive the > surface as linear and have a single base register which is reprogrammed > using the flip. > > Signed-off-by: Chris Wilson > Cc: Jesse Barnes > Reported-by: Marty Jack > --- > drivers/gpu/drm/i915/intel_display.c | 67 ++++++++++++++++++++++++---------- > 1 files changed, 48 insertions(+), 19 deletions(-) Looks good. Marty, any chance you could reply with a tested-by? Reviewed-by: Jesse Barnes -- Jesse Barnes, Intel Open Source Technology Center