From: Jan Kara Subject: Re: [PATCH -next] quota: fix QUOTACTL kconfig for gfs2 Date: Thu, 12 Aug 2010 04:46:11 +0200 Message-ID: <20100812024611.GD14762@quack.suse.cz> References: <20100811162435.882687bf.randy.dunlap@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-fsdevel@vger.kernel.org, Jan Kara , Steven Whitehouse To: Randy Dunlap Return-path: Received: from cantor2.suse.de ([195.135.220.15]:58762 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759385Ab0HLCqr (ORCPT ); Wed, 11 Aug 2010 22:46:47 -0400 Content-Disposition: inline In-Reply-To: <20100811162435.882687bf.randy.dunlap@oracle.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Wed 11-08-10 16:24:35, Randy Dunlap wrote: > From: Randy Dunlap > > warning: (GFS2_FS && BLOCK && EXPERIMENTAL && (64BIT || LBDAF)) selects QUOTACTL which has unmet direct dependencies (XFS_QUOTA || QUOTA) > > Signed-off-by: Randy Dunlap > Cc: Steven Whitehouse > Cc: cluster-devel@redhat.com > --- > fs/quota/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > However, the "depends on" line here seems like overkill to me. OK, so do you mean that making QUOTACTL default to 'n', removing the depends on line and letting QUOTA, XFS_QUOTA, and GFS2_QUOTA select QUOTACTL would be better? Honza > > > --- linux-next-20100810.orig/fs/quota/Kconfig > +++ linux-next-20100810/fs/quota/Kconfig > @@ -65,7 +65,7 @@ config QFMT_V2 > > config QUOTACTL > bool > - depends on XFS_QUOTA || QUOTA > + depends on XFS_QUOTA || QUOTA || GFS2_FS > default y > > config QUOTACTL_COMPAT -- Jan Kara SUSE Labs, CR