Received: from mailman by lists.gnu.org with archive (Exim 4.43)
	id 1Olf7F-00055r-Ou
	for mharc-grub-devel@gnu.org; Wed, 18 Aug 2010 05:39:25 -0400
Received: from [140.186.70.92] (port=34181 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Olf7B-00053a-4X
	for grub-devel@gnu.org; Wed, 18 Aug 2010 05:39:23 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <cjwatson@ubuntu.com>) id 1Olf79-0007Ri-Gh
	for grub-devel@gnu.org; Wed, 18 Aug 2010 05:39:21 -0400
Received: from smarthost03.mail.zen.net.uk ([212.23.3.142]:34539)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <cjwatson@ubuntu.com>) id 1Olf79-0007RQ-CX
	for grub-devel@gnu.org; Wed, 18 Aug 2010 05:39:19 -0400
Received: from [82.69.40.219] (helo=riva.pelham.vpn.ucam.org)
	by smarthost03.mail.zen.net.uk with esmtp (Exim 4.63)
	(envelope-from <cjwatson@ubuntu.com>) id 1Olf77-00020l-Ga
	for grub-devel@gnu.org; Wed, 18 Aug 2010 09:39:17 +0000
Received: from cjwatson by riva.pelham.vpn.ucam.org with local (Exim 3.36 #1
	(Debian)) for grub-devel@gnu.org
	id 1Olf76-0004E4-00; Wed, 18 Aug 2010 10:39:16 +0100
Date: Wed, 18 Aug 2010 10:39:16 +0100
From: Colin Watson <cjwatson@ubuntu.com>
To: The development of GNU GRUB <grub-devel@gnu.org>
Message-ID: <20100818093916.GC21862@riva.ucam.org>
References: <20100811114258.25565.89670.stgit@yves.private.network>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20100811114258.25565.89670.stgit@yves.private.network>
User-Agent: Mutt/1.5.18 (2008-05-17)
X-Originating-Smarthost03-IP: [82.69.40.219]
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3)
Subject: Re: [PATCH] Bash completion script for grub util commands
X-BeenThere: grub-devel@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: The development of GNU GRUB <grub-devel@gnu.org>
List-Id: The development of GNU GRUB <grub-devel.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/grub-devel>
List-Post: <mailto:grub-devel@gnu.org>
List-Help: <mailto:grub-devel-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 18 Aug 2010 09:39:23 -0000

On Wed, Aug 11, 2010 at 01:42:58PM +0200, Yves Blusseau wrote:
>  ChangeLog.completion.bash                        |    3 
>  Makefile.in                                      |    4 
>  util/integration/completion/grub-completion.bash |  450 ++++++++++++++++++++++
>  3 files changed, 457 insertions(+), 0 deletions(-)
>  create mode 100644 ChangeLog.completion.bash
>  create mode 100644 util/integration/completion/grub-completion.bash

20:59 <phcoder> cjwatson: is it convenient to install bash_completion scripts in non-bash package?

At least from this point of view, sure, I don't see a problem.  I think
perhaps util/integration/completion/grub-completion.bash is
unnecessarily deep nesting in the source tree though; creating two
levels of subdirectory at once seems a bit much.  If it were me I'd
probably put it in util/bash-completion.d/grub.  (Also, I think the
bikeshed should be pink.)

> diff --git a/ChangeLog.completion.bash b/ChangeLog.completion.bash
> new file mode 100644
> index 0000000..8b1fea9
> --- /dev/null
> +++ b/ChangeLog.completion.bash
> @@ -0,0 +1,3 @@
> +2010-08-11  Yves Blusseau  <blusseau@zetam.org>
> +
> +	* util/integration/completion/grub-completion.bash: New script

I assume that this will in fact go in ChangeLog when committed to trunk.

-- 
Colin Watson                                       [cjwatson@ubuntu.com]