From: Zhenyu Wang Subject: Re: [PATCH] agp/intel: Fix dma mask for Sandybridge Date: Mon, 23 Aug 2010 14:19:22 +0800 Message-ID: <20100823061922.GD29442@zhen-devel.sh.intel.com> References: <20100823013507.GA29442@zhen-devel.sh.intel.com> <20100823054303.GC29442@zhen-devel.sh.intel.com> Reply-To: Zhenyu Wang Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="sfyO1m2EN8ZOtJL6" Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Takashi Iwai Cc: Eric Anholt , David Airlie , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org --sfyO1m2EN8ZOtJL6 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2010.08.23 08:02:42 +0200, Takashi Iwai wrote: >=20 > Also, I don't understand the logic of 40bit addr calculation: >=20 > > static unsigned long intel_gen6_mask_memory(struct agp_bridge_data *bri= dge, > > dma_addr_t addr, int type) > > { > > /* Shift high bits down */ > > addr |=3D (addr >> 28) & 0xff; >=20 > Isn't it 0xff0? >=20 No. This depends on hw 32bit PTE format for sandybridge. bit 31 bit 11 bit 4 bit 0 |<-physical addr 31:12->|<-physical addr 39:32->|<-cache ctl 3:1->|valid| --=20 Open Source Technology Center, Intel ltd. $gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827 --sfyO1m2EN8ZOtJL6 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iEYEARECAAYFAkxyEuoACgkQsQQaM014GCf1YwCgj5rUQFUV8MlM1vV6owKVHoOt hQIAnieiUgTUv6SsPgjNNfyoTKCL/V8G =bsQQ -----END PGP SIGNATURE----- --sfyO1m2EN8ZOtJL6--