From: Mike Frysinger <vapier@gentoo.org>
Date: Wed, 25 Aug 2010 22:04:11 -0400
Subject: [U-Boot] [PATCH] SPI: cmd_spi.c: add option to specify bus and
	mode
In-Reply-To: <4C73A4BD.506@emk-elektronik.de>
References: <4C602B1B.7050800@emk-elektronik.de>
	<AANLkTikD_=B7js1PadzVWiFHAb92_7Nti2L1h9kYEKC2@mail.gmail.com>
	<4C73A4BD.506@emk-elektronik.de>
Message-ID: <201008252204.12504.vapier@gentoo.org>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Tuesday, August 24, 2010 06:53:49 Reinhard Meyer wrote:
> > this usage string no longer makes sense.  how about:
> > "[<bus>:]<cs>[.<mode>] <bit_len> <dout> - Send <bit_len> bits from
> > <dout> out the SPI\n"
> 
> The problem is, that without blowing up the parser even more, only
> 2 forms of the command are valid:
> 
> the classic form
> 
> <cs> <bit_len> <dout>
> 
> or
> 
> <bus>:<cs>[.<mode>] <bit_len> <dout>

how so ?  the bus:cs.mode field is always going to be one argv, and your patch 
has it so that argv[1] is always parsed against this form.  i dont see where 
this limitation is that you're seeing ...
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20100825/0c095ac0/attachment.pgp