From: Ben Hutchings Subject: Re: [PATCH] i915, drm: Fix build dependency on VGA_ARB Date: Thu, 26 Aug 2010 16:59:21 +0100 Message-ID: <20100826155921.GL5063@decadent.org.uk> References: <20100826145917.GA3267@a1.tnic> <20100826152954.GA29091@Pilar.aei.mpg.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from shadbolt.e.decadent.org.uk (shadbolt.e.decadent.org.uk [88.96.1.126]) by gabe.freedesktop.org (Postfix) with ESMTP id BF7B79F0FA for ; Thu, 26 Aug 2010 08:59:42 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20100826152954.GA29091@Pilar.aei.mpg.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: "Carlos R. Mafra" Cc: dri-devel@lists.freedesktop.org, Borislav Petkov , Matthew Garrett List-Id: dri-devel@lists.freedesktop.org On Thu, Aug 26, 2010 at 05:29:54PM +0200, Carlos R. Mafra wrote: > On Do 26.Aug'10 at 16:59:18 +0200, Borislav Petkov wrote: > > I get: > > > > LD init/built-in.o > > LD .tmp_vmlinux1 > > drivers/built-in.o: In function `intel_modeset_init': > > (.text+0xa993f): undefined reference to `vga_get' > > drivers/built-in.o: In function `intel_modeset_init': > > (.text+0xa9963): undefined reference to `vga_put' > > make: *** [.tmp_vmlinux1] Error 1 > > > > since CONFIG_AGB_ARB is not being selected. Make I915 driver select it > > as the numerous other things it selects. > > > > Signed-off-by: Borislav Petkov > > --- > > > > This is on latest Linus git (v2.6.36-rc2-237-gd4348c6) after doing `make > > oldconfig' on an Acer Aspire One netbook. > > > > drivers/gpu/drm/Kconfig | 1 + > > 1 files changed, 1 insertions(+), 0 deletions(-) > > > > diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig > > index 4cab0c6..43590ab 100644 > > --- a/drivers/gpu/drm/Kconfig > > +++ b/drivers/gpu/drm/Kconfig > > @@ -97,6 +97,7 @@ config DRM_I830 > > config DRM_I915 > > tristate "i915 driver" > > depends on AGP_INTEL > > + select VGA_ARB > > select SHMEM > > select DRM_KMS_HELPER > > select FB_CFB_FILLRECT > > I reported this build failure here: > > http://lkml.org/lkml/2010/8/23/127 > > Is there no other way to fix this? From the Kconfig description > of VGA_ARB I thought I would not need this (and it's a new thing too), > so why make my kernel bigger so easily? should define dummy inline functions if CONFIG_VGA_ARB is not defined. It already does this for vga_client_register() but should cover the other functions as well. Ben. -- Ben Hutchings We get into the habit of living before acquiring the habit of thinking. - Albert Camus