From: Wolfgang Denk Date: Sun, 29 Aug 2010 10:56:47 +0200 Subject: [U-Boot] [PATCH 2/7] Expand POST memory test to support arch-depended implementation. In-Reply-To: <1282944356-4020-2-git-send-email-yorksun@freescale.com> References: <1282944356-4020-1-git-send-email-yorksun@freescale.com> <1282944356-4020-2-git-send-email-yorksun@freescale.com> Message-ID: <20100829085647.D5FCE157D7D@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear York Sun, In message <1282944356-4020-2-git-send-email-yorksun@freescale.com> you wrote: > Add progress indicator for slow test. It is useful when the testing > takes too longer to finish. The indicator is reused from flash > programming. > > Hwconfig is used to turn on slow test when not enabled by flag. NAK. POST is supposed to be an automatic, unmonitored functionality. Results are suposed to be reported through a mechanism compatible to Linux' syslog system. There is no place for progress indicators here. Please note that your subject "support arch-depended implementation" and the commit message "Add progress indicator" are seriously out of sync as well. Another reason for a NAK. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Voodoo Programming: Things programmers do that they know shouldn't work but they try anyway, and which sometimes actually work, such as recompiling everything. - Karl Lehenbauer