From: Wolfgang Denk Date: Thu, 02 Sep 2010 14:05:33 +0200 Subject: [U-Boot] [PATCH v2 2/2] APM82xxx: Add bluestone board support In-Reply-To: <1283390223-28300-1-git-send-email-tmarri@apm.com> References: <1283390223-28300-1-git-send-email-tmarri@apm.com> Message-ID: <20100902120533.493C3153781@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear tmarri at apm.com, In message <1283390223-28300-1-git-send-email-tmarri@apm.com> you wrote: > From: Tirumala Marri > > Add support code for bluestone board wth APM82XXX processor based. > This patch includes early board init, misc init, configure EBC, > initializes UIC, MAKEALL, board.cfg and MAINTAINERS file. > > Signed-off-by: Tirumala R Marri ... > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -253,6 +253,9 @@ Feng Kan > > redwood PPC4xx > > +Tirumala Marri > + bluestone APM82XXX > + > Brad Kemp Please keep list sorted. > +int checkboard(void) > +{ > + char *s = getenv("serial#"); > + > + printf("Board: Bluestone Evaluation Board"); Use puts() if no formatting is needed. > + if (s != NULL) { > + puts(", serial# "); > + puts(s); > + } > + putc('\n'); > +/************************************************************************** > + * TLB TABLE > + * > + * This table is used by the cpu boot code to setup the initial tlb > + * entries. Rather than make broad assumptions in the cpu source tree, > + * this table lets each board set things up however they like. > + * > + * Pointer to the table is returned in r1 > + * > + *************************************************************************/ Incorrect multiline comment style. ... > +#define SPD_EEPROM_ADDRESS {0x53, 0x51} /* SPD i2c spd addresses */ ... > +#define CONFIG_SYS_I2C_EEPROM_ADDR (0xa8 >> 1) ... > +#define CONFIG_4xx_CONFIG_I2C_EEPROM_ADDR 0x52 For consistency with the other settings, please convert the "0xa8 >> 1" into 0x54. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de When all is said and done, more is said than done.