From: Wolfgang Denk Date: Fri, 03 Sep 2010 10:32:53 +0200 Subject: [U-Boot] [PATCH v2 1/2] APM82xxx: Add CPU and other peripheral support In-Reply-To: <201009030946.22440.sr@denx.de> References: <1283390214-28255-1-git-send-email-tmarri@apm.com> <20100902190137.5AEB9153781@gemini.denx.de> <201009030946.22440.sr@denx.de> Message-ID: <20100903083253.BF7C9153781@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Stefan Roese, In message <201009030946.22440.sr@denx.de> you wrote: > > IIRC, then the main reason for this is the code size reduction. Using your > version would increase the code size quite a bit. But I concur, it would be > much better readable. So just let me know, and I'll try to come up with a > patch cleaning this up a bit. Maybe some common parts (like "AMCC PowerPC ") could be split off. For the rest, the compelex code needs also space, so I'm not sure about the end result. > As described in some comments, the problem is that some SoC's have the same > PVR (for example 440EP rev C and 440GR rev B have same PVR). I have no idea > how this identification could be solved without such ifdef's. I see. > But you are right. Some of the ifdef's can be removed. Again, this would also > result in a bigger image size though. Really? We should measure the effect. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de The most exciting phrase to hear in science, the one that heralds new discoveries, is not "Eureka!" (I found it!) but "That's funny ..." -- Isaac Asimov