From: Wolfgang Denk Date: Thu, 09 Sep 2010 12:42:13 +0200 Subject: [U-Boot] [PATCH 2/4 v2] cfi_flash: Add weak default for cfi_flash_bank_addr() In-Reply-To: <1284026772-16694-1-git-send-email-sr@denx.de> References: <1284026772-16694-1-git-send-email-sr@denx.de> Message-ID: <20100909104213.E5908153798@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Stefan Roese, In message <1284026772-16694-1-git-send-email-sr@denx.de> you wrote: > cfi_flash_bank_addr(int bank_nr) returns the base addresses of the > requested bank. Introducing this weak default enables boards to override > this functions with a board specific version when required. ... > + return ((phys_addr_t [])CONFIG_SYS_FLASH_BANKS_LIST)[i]; ... > -#define BANK_BASE(i) (((phys_addr_t [CFI_MAX_FLASH_BANKS])CONFIG_SYS_FLASH_BANKS_LIST)[i]) Was the change from "[CFI_MAX_FLASH_BANKS]" to "[]" intentional? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Teenagers are people who express a burning desire to be different by dressing exactly alike. There are some strings. They're just not attached.