From: Wolfgang Denk Date: Thu, 09 Sep 2010 16:53:20 +0200 Subject: [U-Boot] [PATCH v3 1/2] APM821xx: Add CPU support In-Reply-To: <201009091645.16076.sr@denx.de> References: <1283911581-16085-1-git-send-email-tmarri@apm.com> <201009091645.16076.sr@denx.de> Message-ID: <20100909145320.AD2B81506AA@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Stefan Roese, In message <201009091645.16076.sr@denx.de> you wrote: > > > include/apm821xx.h | 493 +++++++++++++++++++++++++++++++ > > I know that Wolfgang specifically asked you to add this file for this > "new" SoC. But I'm not so sure if this is the right way. Most of the > defines in this new file are a plain copy from include/ppc440.h. > > Wolfgang, do you really think this is better than adding support for > this SoC into ppc440.h? After all, the CPU core of this SoC is still > a PPC4xx PowerPC. It makes no sense to duplicate common parts. Only different code should be moved to separate files. Viele Gr??e, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de When in doubt, mumble; when in trouble, delegate; when in charge, ponder. -- James H. Boren