Received: from [140.186.70.92] (port=44798 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ou58F-0008H5-U8 for qemu-devel@nongnu.org; Fri, 10 Sep 2010 11:03:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Ou586-0005vF-Qa for qemu-devel@nongnu.org; Fri, 10 Sep 2010 11:03:11 -0400 Received: from zimbra3.corp.accelance.fr ([213.162.49.233]:47285) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Ou586-0005uu-Jv for qemu-devel@nongnu.org; Fri, 10 Sep 2010 11:03:06 -0400 From: Thomas Monjalon Subject: Re: [Qemu-devel] [PATCH] target-ppc: clear MSR_POW on interrupt Date: Fri, 10 Sep 2010 17:03:01 +0200 References: <20100721085316.10710.28700.malonedeb@soybean.canonical.com> <201009101432.06340.thomas.monjalon@openwide.fr> <4C8A2C71.6040604@suse.de> In-Reply-To: <4C8A2C71.6040604@suse.de> MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <201009101703.02612.thomas.monjalon@openwide.fr> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Alexander Graf Alexander Graf wrote: > Thomas Monjalon wrote: > > From: till <608107@bugs.launchpad.net> > > > > According to FreeScale's 'Programming Environments Manual for 32-bit > > Implementations of the PowerPC Architecture' [MPCFPE32B, Rev.3, 9/2005], > > section 6.5, table 6-7, an interrupt resets MSR_POW to zero but > > qemu-0.12.4 fails to do so. > > Resetting the bit is necessary in order to bring the processor out of > > power management since otherwise it goes to sleep right away in the > > exception handler, i.e., it is impossible to leave PM-mode. > > This doesn't look right. POW shouldn't even get stored in SRR1. Could > you please redo the patch and make sure that mtmsr masks out MSR_POW? Could you point sections of the specification for these requirements ? I think SRR1 can save any bits. Non significant bits can be overriden and are masked out when RFI occurs. -- Thomas