From: Tim Deegan Subject: Re: [PATCH 13/13] Nested Virtualiztion: hap-on-hap Date: Mon, 13 Sep 2010 10:28:28 +0100 Message-ID: <20100913092828.GA3844@whitby.uk.xensource.com> References: <201009011718.44873.Christoph.Egger@amd.com> <20100908140451.GA23487@whitby.uk.xensource.com> <201009091601.04316.Christoph.Egger@amd.com> <1A42CE6F5F474C41B63392A5F80372B22A86CEE7@shsmsx501.ccr.corp.intel.com> <20100910100309.GB29761@whitby.uk.xensource.com> <1A42CE6F5F474C41B63392A5F80372B22A86D875@shsmsx501.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Return-path: Content-Disposition: inline In-Reply-To: <1A42CE6F5F474C41B63392A5F80372B22A86D875@shsmsx501.ccr.corp.intel.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: "Dong, Eddie" Cc: Christoph Egger , "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org At 06:53 +0100 on 13 Sep (1284360838), Dong, Eddie wrote: > Tim Deegan wrote: > > At 02:37 +0100 on 10 Sep (1284086227), Dong, Eddie wrote: > >> wording is always a challenge in nested virtualization :( > >> > >> I have similar feeling and thinking. In all the explaination text, we > >> use the term l1 guest, l2 guest which makes everybody easy to > >> understand, but in the code we are avoiding those clear prefix both > >> here and in Qing's patch. How about we use l1/l2 prefix more to > >> explicitly differentiate among them? Just 2 cents, it may be too > >> later. > > > > That sounds like a good idea. My only reservation is that it might be > > confusing since we already use l1 and l2 when naming levels of > > pagetables, so e.g. the shadow code has variables called l2gfn. > > > > Maybe we could use n0, n1, n2 for nesting levels instead? > > > Or l1g, l2g? Anyway, either is better to me and up to your decision. I think I prefer n1, n2 - just because it's shorter. :) Tim. -- Tim Deegan Principal Software Engineer, XenServer Engineering Citrix Systems UK Ltd. (Company #02937203, SL9 0BG)