From: Tim Deegan Subject: Re: [PATCH 06/16] vmx: nest: handling VMX instruction exits Date: Mon, 13 Sep 2010 12:11:30 +0100 Message-ID: <20100913111130.GE3844@whitby.uk.xensource.com> References: <1283959344-3837-1-git-send-email-qing.he@intel.com> <1283959344-3837-7-git-send-email-qing.he@intel.com> <1A42CE6F5F474C41B63392A5F80372B22A86D1F9@shsmsx501.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Return-path: Content-Disposition: inline In-Reply-To: <1A42CE6F5F474C41B63392A5F80372B22A86D1F9@shsmsx501.ccr.corp.intel.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: "Dong, Eddie" Cc: "xen-devel@lists.xensource.com" , "He, Qing" List-Id: xen-devel@lists.xenproject.org At 08:05 +0100 on 10 Sep (1284105901), Dong, Eddie wrote: > Qing He wrote: > > +static int __clear_current_vvmcs(struct vmx_nest_struct *nest) > > +{ > > + int rc; > > + > > + if ( nest->svmcs ) > > + __vmpclear(virt_to_maddr(nest->svmcs)); > > + > > +#if !CONFIG_VVMCS_MAPPING > > + rc = hvm_copy_to_guest_phys(nest->gvmcs_pa, nest->vvmcs, > > > Qing: > Why this may be failure? The only reason may be nest->gvmcs_pa, but I guess we already verified the address. > It was verified at load time, but the guest could have ballooned it out in the meantime. Cheers, Tim -- Tim Deegan Principal Software Engineer, XenServer Engineering Citrix Systems UK Ltd. (Company #02937203, SL9 0BG)