From: Nick Bowler Date: Mon, 13 Sep 2010 21:11:06 +0000 Subject: Re: [PATCH 18/25] drivers/serial/suncore.c: Use static const char Message-Id: <20100913211106.GA4200@elliptictech.com> List-Id: References: <0ab674aa32a5fcc364982c78efdf44864a61523b.1284406639.git.joe@perches.com> <20100913213613.223e10a5@lxorguk.ukuu.org.uk> <1284409338.26719.47.camel@Joe-Laptop> In-Reply-To: <1284409338.26719.47.camel@Joe-Laptop> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Joe Perches Cc: Alan Cox , linux-kernel@vger.kernel.org, "David S. Miller" , sparclinux@vger.kernel.org On 2010-09-13 13:22 -0700, Joe Perches wrote: > It tries to standardize the style use and it avoids possible > future checkpatch warnings of: > char foo[] = "bar" > char array could possibly be static const. Whoa, back up a second here. I've seen patches to avoid questionable checkpatch warnings before, but I think this is the first time I've seen a patch to avoid *hypothetical checkpatch warnings that don't even exist*! -- Nick Bowler, Elliptic Technologies (http://www.elliptictech.com/)