Received: from [140.186.70.92] (port=53776 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OvNyd-0005O0-56 for qemu-devel@nongnu.org; Tue, 14 Sep 2010 01:22:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OvNyb-0000yX-7a for qemu-devel@nongnu.org; Tue, 14 Sep 2010 01:22:43 -0400 Received: from mail-pw0-f45.google.com ([209.85.160.45]:48112) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OvNyb-0000yR-1c for qemu-devel@nongnu.org; Tue, 14 Sep 2010 01:22:41 -0400 Received: by pwj4 with SMTP id 4so2443848pwj.4 for ; Mon, 13 Sep 2010 22:22:39 -0700 (PDT) Date: Tue, 14 Sep 2010 13:22:34 +0800 From: amateur Message-ID: <20100914052234.GA10008@localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Subject: [Qemu-devel] [PATCH] linux-user: mmap_reserve() not controlled by RESERVED_VA Reply-To: amateur List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Qemu Devel mmap_reserve() should be called only when RESERVED_VA is enabled. Otherwise, unmaped virtual address space will never be reusable. This bug will exhaust virtual address space in extreme conditions. diff --git a/linux-user/mmap.c b/linux-user/mmap.c index e10a6ef..50748a2 100644 --- a/linux-user/mmap.c +++ b/linux-user/mmap.c @@ -697,7 +697,9 @@ abi_long target_mremap(abi_ulong old_addr, abi_ulong old_size, old_size, new_size, flags | MREMAP_FIXED, g2h(mmap_start)); - mmap_reserve(old_addr, old_size); + if ( RESERVED_VA ) { + mmap_reserve(old_addr, old_size); + } } } else { int prot = 0; -- If you don't drink it, someone else will.