From: Matt Helsley Subject: Re: [PATCH 2/8] sysvshm: report error on failure to reattach, avoid crash Date: Tue, 14 Sep 2010 20:04:51 -0700 Message-ID: <20100915030451.GH8957@count0.beaverton.ibm.com> References: <1284494530-25946-1-git-send-email-ntl@pobox.com> <1284494530-25946-3-git-send-email-ntl@pobox.com> <20100915025502.GG8957@count0.beaverton.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20100915025502.GG8957-52DBMbEzqgQ/wnmkkaCWp/UQ3DHhIser@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Matt Helsley Cc: containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, Nathan Lynch List-Id: containers.vger.kernel.org On Tue, Sep 14, 2010 at 07:55:03PM -0700, Matt Helsley wrote: > On Tue, Sep 14, 2010 at 03:02:04PM -0500, Nathan Lynch wrote: > > If ipcshm_restore fails to look up the file object for the region > > being restored, it should return the error to its caller and not > > proceed to dereference the file pointer. > > > > Signed-off-by: Nathan Lynch > > (Important fix. Adding Oren to Cc) Argh. I was so busy verifying that __must_check didn't warn about the bug that I neglected to do this. Sorry for the noise! Oren please have a look at this thread. Cheers, -Matt