From: Wolfgang Denk Date: Thu, 16 Sep 2010 23:27:21 +0200 Subject: [U-Boot] [PATCH] [v2] p1022ds: use weak CFI flash accessors when DIU is enabled In-Reply-To: <1284667916-11233-1-git-send-email-timur@freescale.com> References: <1284667916-11233-1-git-send-email-timur@freescale.com> Message-ID: <20100916212721.88390135159@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Timur Tabi, In message <1284667916-11233-1-git-send-email-timur@freescale.com> you wrote: > On the Freescale P1022, the DIU and the LBC share address pins, which means > that when the DIU is active (e.g. the console is on the DVI display), NOR flash > cannot be accessed. So we use the weak accessor function feature of the CFI > flash code to temporarily switch the pin mux from LBC to DIU whenever we want > to read or write flash. This has a significant performance penalty, but it's > the only way to make it work. > > This change allows the 'saveenv' command to work when the video display is > enabled. Writing to flash with the 'cp' command works, but reading from flash > with the 'md' and 'cp' commands does not. Also, while flash is being written > to, the video display will be blank. > > Signed-off-by: Timur Tabi > --- > > v2: found another place to use the PMUXCR_ELBCDIU_xxx macros Same comments as previous version. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de A good aphorism is too hard for the tooth of time, and is not worn away by all the centuries, although it serves as food for every epoch. - Friedrich Wilhelm Nietzsche _Miscellaneous Maxims and Opinions_ no. 168