From: Jeff Layton Subject: Re: samba changing mode of files on rename Date: Fri, 17 Sep 2010 13:15:58 -0400 Message-ID: <20100917131558.13a00c53@corrin.poochiereds.net> References: <20100917130005.23d0864a@corrin.poochiereds.net> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: linux-cifs@vger.kernel.org, samba-technical@lists.samba.org To: Jeff Layton Return-path: In-Reply-To: <20100917130005.23d0864a@corrin.poochiereds.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: samba-technical-bounces@lists.samba.org Errors-To: samba-technical-bounces@lists.samba.org List-Id: linux-cifs.vger.kernel.org On Fri, 17 Sep 2010 13:00:05 -0400 Jeff Layton wrote: > I recently noticed a regression in samba in the last few weeks. Here's > a simple way to reproduce it: > > 1) use smbclient to put a file on a samba share > 2) change the mode of the file to something without the owner execute bit set > 3) rename the file using smbclient > > When you do this, the newly renamed file will magically end up with the > owner execute bit set. It seems like samba ought not be changing the > mode of files when renaming them so I consider this a regression. > > I've reported the bug in the Fedora BTS, and attached some info there. > Anyone more familiar with this code willing to have a look? > > https://bugzilla.redhat.com/show_bug.cgi?id=617771 > > I've was able to reproduce it today using the most recent samba version > available in the Fedora repos (3.5.5). > > Thanks, Volker pointed out a workaround on IRC... If I set "map archive = no" then this doesn't seem to happen. So, I guess something has happened relatively recently to make renames set the archive bit? -- Jeff Layton